-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration: Add case about destroy vm #5935
Conversation
Test result: (1/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_before_vm_paused.with_precopy.p2p: STARTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
XXX-298199 - [VM migration][async ops] destroy vm during PerformPhase of migration Signed-off-by: lcheng <[email protected]>
|
||
test.log.info("Verify steps.") | ||
if not libvirt.check_vm_state(vm.name, expected_src_state, uri=migration_obj.src_uri): | ||
test.faile("Check vm state on source host fail.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stupid question ... isn't this typo? added "e" at the end of test.faile.
Also the message is not very descriptive.
I would suggest to give more details.
test.fail(f"Check of expected VM state ({expected_src_state}) on source host failed.")
it would be good to to see actual state of the VM .. not sure if it is also listed anywhere around in log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to to see actual state of the VM .. not sure if it is also listed anywhere around in log.
I agree. I will submit a PR to avocado-vt to print actual state of the VM. Thanks.
XXX-298199 - [VM migration][async ops] destroy vm during PerformPhase of migration